Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displaying Pull Request Panel #8905

Merged
merged 1 commit into from
Feb 27, 2018
Merged

Fix displaying Pull Request Panel #8905

merged 1 commit into from
Feb 27, 2018

Conversation

RomanNikitenko
Copy link
Member

What does this PR do?

  • Fix restoring state of Pull Request Panel after refreshing page, start/stop workspace
  • Control the PR Panel displaying corresponding to saved state when selection is changed
  • Provide content for the PR Panel when Tooling part stack is opening (by Panel selector, for example)

So at first we show the PR Panel, once it is closed, it must stay closed
User can display the panel:

  • using Panel selector
  • from menu Assistant -> Tool Windows ->Contribute action
  • by hot key

panelselector

contributeaction

What issues does this PR fix or reference?

#7975
#7771
Signed-off-by: Roman Nikitenko rnikiten@redhat.com

@RomanNikitenko
CHE-7975. Fix displaying Pull Request Panel
1bf9b9a 
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
@RomanNikitenko RomanNikitenko added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Feb 24, 2018
@RomanNikitenko
Copy link
Member Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:8905
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

artaleks9
artaleks9 approved these changes Feb 27, 2018
View reviewed changes
Copy link
Contributor

@artaleks9 artaleks9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test report is OK

@RomanNikitenko RomanNikitenko added this to the 6.2.0 milestone Feb 27, 2018
@RomanNikitenko RomanNikitenko merged commit ae9d989 into master Feb 27, 2018
@RomanNikitenko RomanNikitenko deleted the CHE-7975 branch February 27, 2018 13:43
@RomanNikitenko RomanNikitenko removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Feb 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov approved these changes

@artaleks9 artaleks9 artaleks9 approved these changes

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@RomanNikitenko @codenvy-ci @vparfonov @artaleks9