Add setting of an environment variable to configure master logs encoding #9296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benoitf
added
status/code-review
garagatyi
changed the title
garagatyi
changed the title
Add setting of env var CHE_LOGS_APPENDERS_IMPL that sets Che master logs producing configuration to deployments for: - docker (che.env) - kubernetes (kubectl) - kubernetes (helm) - openshift (scripts) Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com> Signed-off-by: Oleksandr Garagatyi <ogaragat@redhat.com>
|
@perspectivus1 @guydaichs FYI |
sleshchenko
reviewed
Mar 30, 2018
| # Choose variant of Che master logs encoding and storing. Default is `plaintext`. | ||
| # Another supported value is `json` which makes Che master produce JSON encoded logs | ||
| # in system output of PID 1 process of container. Useful for storing logs in systems such as Logstash. | ||
| # CHE_LOGS_APPENDERS_IMPL=plaintext |
There was a problem hiding this comment.
Shouldn't default value be added into che.properties?
There was a problem hiding this comment.
No, it is not read from properties
riuvshin
reviewed
Mar 30, 2018
| # Choose variant of Che master logs encoding and storing. Default is `plaintext`. | ||
| # Another supported value is `json` which makes Che master produce JSON encoded logs | ||
| # in system output of PID 1 process of container. Useful for storing logs in systems such as Logstash. | ||
| # CHE_LOGS_APPENDERS_IMPL=plaintext |
There was a problem hiding this comment.
if that is commented, the default value will be used, do we have default value declared in a code? because I do not see it in the che.props
There was a problem hiding this comment.
I think the default value is declared here
There was a problem hiding this comment.
@l0rd is right this value is not read by the code and default value is in xml file of logback
l0rd
reviewed
Mar 30, 2018
|
@l0rd here is a PR for the docs eclipse-che/che-docs#384 |
garagatyi
changed the title
|
@l0rd @riuvshin @sleshchenko @eivantsov I've merged the PR in che-lib so we can proceed with this one. Can you review the PR? |
benoitf
approved these changes
Apr 5, 2018
l0rd
approved these changes
Apr 5, 2018
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add setting of master logs encoding to che.env.
What issues does this PR fix or reference?
Related to #9275, eclipse-che/che-lib#83
Release Notes
Docs PR
eclipse-che/che-docs#384