Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to manage the list of Theia plugins in UD #9300

Merged
merged 3 commits into from
Apr 3, 2018
Merged

Conversation

ashumilova
Copy link
Contributor

@ashumilova ashumilova commented Mar 30, 2018

Signed-off-by: Anna Shumilova ashumilo@redhat.com

What does this PR do?

Adds the ability to manage the list of Theia plugins in UD and add custom plugins.

What issues does this PR fix or reference?

#8695

@ashumilova ashumilova added kind/enhancement A feature request - must adhere to the feature request template. status/in-progress This issue has been taken by an engineer and is under active development. labels Mar 30, 2018
@ashumilova
Copy link
Contributor Author

ci-test

@@ -0,0 +1,65 @@
/*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would assume the managing of plugins would be server side instead of client side (like searching all extensions).
So it doesn't use client connection to download plugins but use server side.

But it may be for step 2

@@ -152,11 +152,15 @@ class IdeCtrl {
return;
}

if (this.ideSvc.openedWorkspace && this.selectedWorkspace.id === this.ideSvc.openedWorkspace.id) {
// todo commented for testing purposes - with IDE running inside container - after workspace restart - location changes,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

before merging, need to remove comments or put it back

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9300
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova ashumilova added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. and removed status/in-progress This issue has been taken by an engineer and is under active development. labels Apr 2, 2018
@ashumilova
Copy link
Contributor Author

ci-test

@codenvy-ci
Copy link

ci-test build report:
Build details
Test report
selenium tests report data
docker image: eclipseche/che-server:9300
https://github.com/orgs/eclipse/teams/eclipse-che-qa please check this report.

@ashumilova ashumilova merged commit 425a5da into master Apr 3, 2018
@ashumilova ashumilova deleted the plugins branch April 3, 2018 07:40
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 3, 2018
@benoitf benoitf added this to the 6.4.0 milestone Apr 3, 2018
skabashnyuk pushed a commit that referenced this pull request Jan 3, 2020
* Manage the list of Theia plugins in UD

Signed-off-by: Anna Shumilova <ashumilo@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants