Use workspace limit idle timeout value in WorkspaceActivityManager #9342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkuznyetsov
requested review from
benoitf,
garagatyi and
riuvshin
as code owners
benoitf
added
status/code-review
mshaposhnik
approved these changes
Apr 5, 2018
|
Pls write more meaningful title. |
mkuznyetsov
changed the title
benoitf
approved these changes
Apr 5, 2018
|
ci-test |
skabashnyuk
reviewed
Apr 5, 2018
| @@ -32,3 +32,5 @@ che.infra.kubernetes.installer_server_max_port=che.infra.openshift.installer_ser | |||
|
|
|||
| che.infra.docker.daemon_url=docker.client.daemon_url | |||
| che.infra.docker.certificates_folder=docker.client.certificates_folder | |||
|
|
|||
| che.limits.workspace.idle.timeout=che.workspace.agent.dev.inactive_stop_timeout_ms | |||
| @@ -32,3 +32,5 @@ che.infra.kubernetes.installer_server_max_port=che.infra.openshift.installer_ser | |||
|
|
|||
| che.infra.docker.daemon_url=docker.client.daemon_url | |||
| che.infra.docker.certificates_folder=docker.client.certificates_folder | |||
|
|
|||
There was a problem hiding this comment.
comment why we need it.
sleshchenko
approved these changes
Apr 5, 2018
…aceActivityManager
skabashnyuk
approved these changes
Apr 5, 2018
|
ci-test build report: |
riuvshin
approved these changes
Apr 6, 2018
garagatyi
approved these changes
Apr 10, 2018
|
@riuvshin no, it doesn't. |
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WorkspaceActivityManager is now using accounts resources to retrieve workspaces idle timeouts. "che.limits.workspace.idle.timeout" property is also used now as default value for timeout.
Removed old "che.workspace.agent.dev.inactive_stop_timeout_ms" property.
What issues does this PR fix or reference?
#8951
Release Notes
Docs PR