Selenium: Rework the 'CheckoutReferenceTest' to run in the multi-thread mode #9368
Conversation
artaleks9
added
status/code-review
|
ci-test |
| String hashCommit = sha1.substring(0, 8); | ||
| String wrongHashCommit = String.format("%s ##", hashCommit); | ||
| String failMessage = String.format("Branch name %s is not allowed", wrongHashCommit); | ||
| // import the test repo |
There was a problem hiding this comment.
missed empty line before comment
| * | ||
| * @param refName is a name of branch, tag, etc | ||
| * @param branchName is a name of new branch |
There was a problem hiding this comment.
@param branchName name of the branch which should be created
| /** Returns all cells from top row divided by "\n" */ | ||
| private String getGitHistoryTopContent() { | ||
| String rowTopIndex = Integer.toString(0); | ||
| return seleniumWebDriverHelper |
There was a problem hiding this comment.
There is a method SeleniumWebDriverHelper#waitVisibilityAndGetText() which is more suitable here.
| GHRef master = ghRepo.getRef("heads/master"); | ||
| return ghRepo.createRef("refs/heads/" + refName, master.getObject().getSha()); | ||
| public GHRef createBranch(String branchName) throws IOException { | ||
| GHRef defaultBranch = ghRepo.getRef("heads/" + ghRepo.getDefaultBranch()); |
There was a problem hiding this comment.
Please create public method which will be return the default branch
GHRef public getDefaultBranch(){
return ghRepo.getRef("heads/" + ghRepo.getDefaultBranch());
}
There was a problem hiding this comment.
If there are actually no tests which need getDefaultBranch(), I would not create such method because we have already had ghRepo.getDefaultBranch().
There was a problem hiding this comment.
He can create private method. Multiple using the same row
GHRef defaultBranch = ghRepo.getRef("heads/" + ghRepo.getDefaultBranch());
looks not very good
There was a problem hiding this comment.
Method name getReferenceToDefaultBranch() is more relevant to the returning value, IMHO
|
ci-test build report: |
benoitf
removed
the
status/code-review
What does this PR do?
What issues does this PR fix or reference?
#9139, #8153