Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to ocp script #9493

Merged
2 commits merged into from
Apr 19, 2018
Merged

Fixes to ocp script #9493

2 commits merged into from
Apr 19, 2018

Conversation

ghost
Copy link

@ghost ghost commented Apr 19, 2018

  1. Fix grep of CHE_ envs
  2. Make it possible to override IMAGE_PULL_POLICY and UPDATE_STRATEGY
  3. Remove redundant MULTIUSER param

@ghost ghost requested review from garagatyi, l0rd and riuvshin as code owners April 19, 2018 09:06
@benoitf benoitf added kind/bug Outline of a bug - must adhere to the bug report template. status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Apr 19, 2018
sleshchenko
sleshchenko approved these changes Apr 19, 2018
View reviewed changes
Copy link
Member

@sleshchenko sleshchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other LGTM

deploy/openshift/ocp.sh
@@ -41,6 +41,12 @@ export OPENSHIFT_USERNAME=${OPENSHIFT_USERNAME:-${DEFAULT_OPENSHIFT_USERNAME}}
DEFAULT_OPENSHIFT_PASSWORD="developer"
export OPENSHIFT_PASSWORD=${OPENSHIFT_PASSWORD:-${DEFAULT_OPENSHIFT_PASSWORD}}

DEFAULT_IMAGE_PULL_POLICY="Always"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it duplicates the following lines https://github.com/eclipse/che/blob/59230a930dde746678b69acef9ca689c0262e1c2/deploy/openshift/ocp.sh#L74-L75

@ghost ghost merged commit c40a14e into master Apr 19, 2018
@ghost ghost deleted the ocp_fixes branch April 19, 2018 11:10
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label Apr 19, 2018
@benoitf benoitf added this to the 6.5.0 milestone Apr 19, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
Fixes to ocp script (eclipse-che#9493)
d21beaf 
* Fixes to ocp script

* Remove duplicated env
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l0rd l0rd Awaiting requested review from l0rd

Assignees
No one assigned
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Milestone
6.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@riuvshin @garagatyi @sleshchenko @benoitf