Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added an error when keycloak container is not found #9736

Merged
merged 1 commit into from
May 18, 2018

Conversation

sleshchenko
Copy link
Member

What does this PR do?

Adds an error when keycloak container is not found. Earlier when CHE_INFRASTRUCTURE was not set correctly then selenium tests failed with error no such container sh -c because of invalid constructed commands like docker exec -i sh -c where container id is missed.

What issues does this PR fix or reference?

--

Release Notes

N/A

Docs PR

N/A

@sleshchenko sleshchenko self-assigned this May 18, 2018
@benoitf benoitf added status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. kind/enhancement A feature request - must adhere to the feature request template. labels May 18, 2018
@sleshchenko sleshchenko merged commit 15d9ca9 into eclipse-che:master May 18, 2018
@sleshchenko sleshchenko deleted the qa-keycloakContainerId branch May 18, 2018 09:52
@benoitf benoitf removed the status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. label May 18, 2018
@benoitf benoitf added this to the 6.6.0 milestone May 18, 2018
hbhargav pushed a commit to hbhargav/che that referenced this pull request Dec 5, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement A feature request - must adhere to the feature request template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants