Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SSO provider session not invalidated at Kapua session invalidation #2971

Closed
gbarbon opened this issue May 13, 2020 · 0 comments · Fixed by #2992
Closed

SSO provider session not invalidated at Kapua session invalidation #2971

gbarbon opened this issue May 13, 2020 · 0 comments · Fixed by #2992
Labels
Bug This is a bug or an unexpected behaviour. Fix it!

Comments

@gbarbon
Copy link
Member

gbarbon commented May 13, 2020

Describe the bug
When the session expires, the user is logged out from the Kapua console. However, if the user is an external one logged through SSO, he can login again by simply clicking on the 'SSO Login' button, without the need to insert again his credentials. This is due to the SSO session not yet invalidated, while the Kapua Console one already is.

One possible solution would be to simply reduce the time of the SSO session to a lower value than the Kapua Console one. Note that the Kapua Console session time is set though the session-timeout tag in the web.xml in console/web/src/main/webapp/WEB-INF. However, this is not the best option, since there is no synchronisation between the two session. Also, it requires to configure the SSO Provider session timeout at each installation. A better option would be to invalidate the SSO session using the SSO OpenId Connect logout endpoint when the Kapua one is invalidated.

To Reproduce
Steps to reproduce the behavior:

  1. Login to Kapua with an external SSO user (an SSO provider is required)
  2. Wait 30 minutes (the Kapua session timeout), after this amount of time the user should be logged out
  3. Click on the 'SSO Login' button
  4. The user is logged in without the need to insert credentials.

Expected behavior
The SSO session should be invalidated at the same time as the Kapua one.

Screenshots
N/A

Version of Kapua
1.2.0-SNAPSHOT

Type of deployment
[ ] Local Vagrant deployment
[x] Docker
[ ] Openshift (in its variants)
[ ] Others

Main component affected
[x] Console (in case of console please report info on which browser you encountered the problem)
[ ] REST API
[ ] Message Broker
[ ] - Others

Additional context
N/A

@gbarbon gbarbon changed the title SSO provider session not invalidated with Kapua session invalidation SSO provider session not invalidated at Kapua session invalidation May 13, 2020
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants