Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The OpenID idToken should never be 'null' #3041

Closed
gbarbon opened this issue Jul 29, 2020 · 0 comments · Fixed by #3046
Closed

The OpenID idToken should never be 'null' #3041

gbarbon opened this issue Jul 29, 2020 · 0 comments · Fixed by #3046
Assignees
Labels
Bug This is a bug or an unexpected behaviour. Fix it!

Comments

@gbarbon
Copy link
Contributor

gbarbon commented Jul 29, 2020

Is your feature request related to a problem? Please describe.
The OpenID idToken can never be null. The login method of the GwtAuthorizationServiceImpl class already performs a check. However, if the flow does not pass through that method (e.g. in case of tests), the idToken can be null.

Describe the solution you'd like
Add a check on the login method of the AuthenticationServiceShiroImpl class, and throw an exception if the getIdToken() method returns a null value. The ideal portion of code where the check should be added is here.

Describe alternatives you've considered
N/A

Additional context
The OpenID idToken is returned by the OpenID Provider with the accessToken. We use it in Kapua in order to perform the logout from the OpenID Session on the OpenID Provider side (see here for further information).

@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants