Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional statements for OpenID Connect provider selection should be improved #3145

Closed
gbarbon opened this issue Nov 18, 2020 · 0 comments · Fixed by #3146
Closed

Conditional statements for OpenID Connect provider selection should be improved #3145

gbarbon opened this issue Nov 18, 2020 · 0 comments · Fixed by #3146
Assignees
Labels
Enhancement This PR/Issue improves an part of Kapua

Comments

@gbarbon
Copy link
Contributor

gbarbon commented Nov 18, 2020

Is your feature request related to a problem? Please describe.
The conditional expressions in the run-console script for triggering the right OpenID Connect provider should be integrated with an else statement, otherwise the presence of old 'dirty' environment variables of multiple providers might cause unexpected behaviours.

Describe the solution you'd like
Use of elif for the provider selection. The last case should be the generic one, that will also act as a sort of 'fallback' in case of 'dirty' environment. In case the combination of environment variable is not compatible with any provider, no provider will be triggered.

Describe alternatives you've considered
n/a

Additional context
It is worth noting that the proposed solution would not solve completely the issue, but only mitigate it.

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Nov 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants