Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Step properties field having different names #3580

Closed
mmgspr opened this issue Jul 8, 2022 · 1 comment · Fixed by #3759
Closed

Step properties field having different names #3580

mmgspr opened this issue Jul 8, 2022 · 1 comment · Fixed by #3759
Assignees
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Community Request People around asked for it!

Comments

@mmgspr
Copy link

mmgspr commented Jul 8, 2022

Describe the bug
The step properties' field is called different depending on what request are you using.

  • If you are using a POST request, the properties' field in your request's body has to be called "jobStepProperties".
  • If you are using a PUT request, the properties' field in your request's body has to be called "stepProperties".
  • If you use a GET request, the properties' field in your response's body is called "stepProperties".

Expected behavior
The field having the same name in all the requests and responses.

Screenshots
Screenshots taken from the official API documentation: https://www.eclipse.org/kapua/docs/api/index.html?version=1.5.0#/Job%20-%20Step
POST request's body:
Captura de pantalla de 2022-07-08 09-56-57
PUT request's body:
Captura de pantalla de 2022-07-08 09-58-37
GET response's body:
Captura de pantalla de 2022-07-08 09-57-40

Version of Kapua
1.5.X

Main component affected
[ ] Console (in case of console please report info on which browser you encountered the problem)
[X] REST API
[ ] Message Broker
[ ] - Others

@Coduz Coduz self-assigned this Apr 13, 2023
@Coduz Coduz added the Bug This is a bug or an unexpected behaviour. Fix it! label Apr 13, 2023
@Coduz
Copy link
Contributor

Coduz commented Apr 13, 2023

Hi @mmgspr

Thanks for submitting the issue!

@MDeLuise made a PR to fix this issue and make the models uniform between different entities.

Changes made still support old way to define the stepProperties so no immediate change is required upon version upgrade.

Fix will be available in:

  • 2.0.0
  • 1.7.0
  • 16.8
  • 1.5.8

@Coduz Coduz added the Community Request People around asked for it! label Apr 13, 2023
@Coduz Coduz moved this to Done in Eclipse Kapua 1.7.0 Jun 12, 2024
@Coduz Coduz moved this to Done in Eclipse Kapua 1.5.8 Jun 12, 2024
@Coduz Coduz moved this to Done in Eclipse Kapua 2.0.0 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! Community Request People around asked for it!
Projects
Development

Successfully merging a pull request may close this issue.

2 participants