Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump netty4 version from 4.1.34.Final to 4.1.50.Final - CVE-2019-16869 - CWE-113 #3006

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Jun 30, 2020

This PR bumps the version of Netty 4 dependencies to 4.1.50.Final

Related Issue
None

Description of the solution adopted
Bumper to the latest 4.1.x version available.
NO CQ needed while on the same patch release.
CQ for the 4.1.34.Final version here
Each single submodule of Netty 4 has been defined in the dependencyManagement of the root pom.xml so we can match any usages by other dependencies (i.e. Elasticsearch Transport).

Below mvn dependency:tree command issued against develop and this branch.

dependency tree - develop.txt
dependency tree - netty.txt

Screenshots
None

Any side note on the changes made
Netty 3 is still in use by org.elasticsearch.plugin:transport-netty3-client bu t is set on the latest version available. It will be removed when we will drop transport-netty3-client usage.
Branch is named 4.1.45.Final because it was the latest available version at the I created the branch.

@Coduz Coduz added Security This issue/PR has some security critical aspect and should be issued as soon as possible CQ approved The PR has passed CQ approvation labels Jun 30, 2020
@Coduz Coduz requested a review from lorthirk June 30, 2020 07:50
…- CWE-113

Signed-off-by: coduz <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the chng-bumpNettyAllTo4.1.45.Final branch from 2881971 to 5636eec Compare June 30, 2020 07:51
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #3006 into develop will increase coverage by 0.16%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3006      +/-   ##
=============================================
+ Coverage      57.43%   57.59%   +0.16%     
- Complexity      2598     2600       +2     
=============================================
  Files           1062     1062              
  Lines          22988    22988              
  Branches        2043     2043              
=============================================
+ Hits           13203    13240      +37     
+ Misses          8846     8802      -44     
- Partials         939      946       +7     
Impacted Files Coverage Δ Complexity Δ
...pua/broker/core/listener/ErrorMessageListener.java 70.83% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
.../DeviceManagementOperationRegistryServiceImpl.java 69.64% <0.00%> (ø) 14.00% <0.00%> (ø%)
...pse/kapua/commons/service/internal/ServiceDAO.java 74.75% <0.00%> (+0.33%) 0.00% <0.00%> (ø%)
...ages/job/DevicePackageDownloadTargetProcessor.java 100.00% <0.00%> (+5.00%) 9.00% <0.00%> (+1.00%)
...rtz/persistence/KapuaQuartzConnectionProvider.java 100.00% <0.00%> (+12.50%) 5.00% <0.00%> (+1.00%)
...a/kura/simulator/generator/GeneratorScheduler.java 78.12% <0.00%> (+18.75%) 0.00% <0.00%> (ø%)
...ipse/kapua/kura/simulator/generator/Generator.java 100.00% <0.00%> (+33.33%) 0.00% <0.00%> (ø%)
...pua/kura/simulator/app/data/PeriodicGenerator.java 61.40% <0.00%> (+36.84%) 0.00% <0.00%> (ø%)
...clipse/kapua/kura/simulator/generator/Payload.java 50.00% <0.00%> (+50.00%) 0.00% <0.00%> (ø%)

@Coduz Coduz merged commit 92906f6 into eclipse-kapua:develop Jun 30, 2020
@Coduz Coduz deleted the chng-bumpNettyAllTo4.1.45.Final branch June 30, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CQ approved The PR has passed CQ approvation Security This issue/PR has some security critical aspect and should be issued as soon as possible
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants