Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix npe on AbstractKapuaConfigurableResourceLimitedService #3021

Merged
merged 1 commit into from
Jul 9, 2020

Conversation

riccardomodanese
Copy link
Contributor

@riccardomodanese riccardomodanese commented Jul 8, 2020

solves #3020
Deep check for other possible npe must be done.

Signed-off-by: riccardomodanese riccardo.modanese@eurotech.com

Brief description of the PR.
conditional check before converting configuration value to int.

Related Issue
This PR fixes #3020

Description of the solution adopted
A more detailed description of the changes made to solve/close one or more issues.
If the PR is simple and easy to understand this section can be skipped.

Screenshots
If applicable, add screenshots to help explain your solution

Any side note on the changes made
Description of any other change that has been made, which is not directly linked to the issue resolution
[e.g. Code clean up/Sonar issue resolution]

@riccardomodanese riccardomodanese requested a review from lorthirk July 8, 2020 14:52
@riccardomodanese riccardomodanese marked this pull request as draft July 8, 2020 14:52
@riccardomodanese riccardomodanese added the Bug This is a bug or an unexpected behaviour. Fix it! label Jul 8, 2020
@lorthirk lorthirk marked this pull request as ready for review July 8, 2020 15:05
@lorthirk lorthirk force-pushed the fix-npeConfigurableResource branch from 032419c to e081714 Compare July 8, 2020 15:07
…erChildEntities not present

Signed-off-by: riccardomodanese <riccardo.modanese@eurotech.com>
@lorthirk lorthirk force-pushed the fix-npeConfigurableResource branch from e081714 to 0217971 Compare July 8, 2020 15:09
@Coduz Coduz removed the Bug This is a bug or an unexpected behaviour. Fix it! label Jul 8, 2020
@codecov
Copy link

codecov bot commented Jul 8, 2020

Codecov Report

Merging #3021 into develop will increase coverage by 0.04%.
The diff coverage is 50.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3021      +/-   ##
=============================================
+ Coverage      58.06%   58.11%   +0.04%     
- Complexity      2595     2602       +7     
=============================================
  Files           1062     1062              
  Lines          23012    23012              
  Branches        2042     2043       +1     
=============================================
+ Hits           13362    13373      +11     
+ Misses          8699     8689      -10     
+ Partials         951      950       -1     
Impacted Files Coverage Δ Complexity Δ
...stractKapuaConfigurableResourceLimitedService.java 85.71% <50.00%> (-2.39%) 0.00 <0.00> (ø)
...ce/management/commons/call/DeviceCallExecutor.java 62.79% <0.00%> (-4.66%) 0.00% <0.00%> (ø%)
.../jbatch/persistence/JPAPersistenceManagerImpl.java 31.60% <0.00%> (+1.03%) 30.00% <0.00%> (ø%)
...apua/job/engine/jbatch/JobEngineServiceJbatch.java 51.85% <0.00%> (+1.85%) 8.00% <0.00%> (ø%)
...nnection/internal/DeviceConnectionServiceImpl.java 69.66% <0.00%> (+2.24%) 17.00% <0.00%> (+1.00%)
...atch/persistence/jpa/JpaExecutionInstanceData.java 90.24% <0.00%> (+2.43%) 23.00% <0.00%> (+1.00%)
.../DeviceManagementOperationRegistryServiceImpl.java 69.64% <0.00%> (+3.57%) 14.00% <0.00%> (+2.00%)
...rtz/persistence/KapuaQuartzConnectionProvider.java 100.00% <0.00%> (+12.50%) 5.00% <0.00%> (+1.00%)
...ob/engine/jbatch/exception/JobEngineException.java 66.66% <0.00%> (+33.33%) 2.00% <0.00%> (+1.00%)
.../engine/jbatch/exception/JobResumingException.java 50.00% <0.00%> (+50.00%) 1.00% <0.00%> (+1.00%)

@Coduz Coduz merged commit 5d43729 into develop Jul 9, 2020
@Coduz Coduz deleted the fix-npeConfigurableResource branch July 9, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbstractKapuaConfigurableResourceLimitedService throws npe if maxNumberChildEntities is not present
3 participants