Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users Match Predicate #3051

Merged
merged 2 commits into from
Aug 27, 2020

Conversation

lorthirk
Copy link

@lorthirk lorthirk commented Aug 13, 2020

Following the Devices Match Predicates in #2875, this PR introduces a UserMatchPredicates. Evaluated properties are:

  • NAME
  • EMAIL
  • PHONE_NUMBER
  • DISPLAY_NAME
  • EXTERNAL_ID
  • DESCRIPTION

Related Issue
No related issues

Any side note on the changes made
The PR also refactors the DeviceMatchPredicate to have a public interface and an internal implementation, to better isolate the one from the other

@lorthirk lorthirk added Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday labels Aug 13, 2020
@lorthirk lorthirk requested a review from Coduz August 13, 2020 10:41
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #3051 into develop will increase coverage by 0.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3051      +/-   ##
=============================================
+ Coverage      57.79%   57.91%   +0.11%     
+ Complexity      2596     2593       -3     
=============================================
  Files           1061     1062       +1     
  Lines          22874    22879       +5     
  Branches        2028     2028              
=============================================
+ Hits           13221    13250      +29     
+ Misses          8710     8681      -29     
- Partials         943      948       +5     
Impacted Files Coverage Δ Complexity Δ
...ce/registry/internal/DeviceMatchPredicateImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...vice/device/registry/internal/DeviceQueryImpl.java 85.71% <0.00%> (ø) 2.00 <0.00> (ø)
.../service/user/internal/UserMatchPredicateImpl.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...pse/kapua/service/user/internal/UserQueryImpl.java 83.33% <0.00%> (-16.67%) 2.00 <0.00> (ø)
.../engine/jbatch/exception/JobResumingException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0.00%> (-33.34%) 1.00% <0.00%> (-1.00%)
...pse/kapua/service/tag/internal/TagServiceImpl.java 82.22% <0.00%> (-8.89%) 14.00% <0.00%> (-2.00%)
...pua/broker/core/listener/ErrorMessageListener.java 70.83% <0.00%> (-8.34%) 0.00% <0.00%> (ø%)
...a/service/device/registry/internal/DeviceImpl.java 71.11% <0.00%> (-4.45%) 65.00% <0.00%> (-2.00%)
...rvice/device/registry/common/DeviceValidation.java 70.00% <0.00%> (-3.75%) 14.00% <0.00%> (-1.00%)
... and 17 more

Claudio Mezzasalma added 2 commits August 26, 2020 14:23
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the feature-usersMatchPredicate branch from d20d21e to cca4c61 Compare August 26, 2020 12:26
@Coduz Coduz merged commit b8890da into eclipse-kapua:develop Aug 27, 2020
@lorthirk lorthirk deleted the feature-usersMatchPredicate branch October 19, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants