-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Storable API Refactoring #3073
Merged
Coduz
merged 6 commits into
eclipse-kapua:develop
from
Coduz:feature-storableApiRefactor
Oct 12, 2020
Merged
Storable API Refactoring #3073
Coduz
merged 6 commits into
eclipse-kapua:develop
from
Coduz:feature-storableApiRefactor
Oct 12, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #3073 +/- ##
=============================================
+ Coverage 62.87% 62.89% +0.01%
+ Complexity 2636 2576 -60
=============================================
Files 1116 1107 -9
Lines 23343 23072 -271
Branches 2008 1986 -22
=============================================
- Hits 14677 14511 -166
+ Misses 7742 7653 -89
+ Partials 924 908 -16
|
Coduz
force-pushed
the
feature-storableApiRefactor
branch
9 times, most recently
from
September 24, 2020 08:04
79082d7
to
a9ddfcb
Compare
Coduz
force-pushed
the
feature-storableApiRefactor
branch
4 times, most recently
from
October 5, 2020 12:21
554727c
to
88a036f
Compare
Coduz
force-pushed
the
feature-storableApiRefactor
branch
4 times, most recently
from
October 9, 2020 09:26
6c9392c
to
14e15bb
Compare
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…nal module Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
…bunch of Javadoc to classes Signed-off-by: coduz <alberto.codutti@eurotech.com>
Signed-off-by: coduz <alberto.codutti@eurotech.com>
Coduz
force-pushed
the
feature-storableApiRefactor
branch
from
October 12, 2020 09:12
14e15bb
to
5155fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the Storable API and its base implementation.
Currently all Storable API (used for Elasticsearch enabled services) are contained into
kapua-datastore-api
andkapua-datastore-internal
which make reuse of them not clean since you have to depend on datastore modules instead of common modules.Related Issue
None
Description of the solution adopted
Moved Storable API clases to
kapua-service-api
module.Moved Storable base implementation classes to a new module
kapua-service-storable
Improved the implementation with some goodies added to the
KapuaEntity
-enabled classes but were not ported to the Storable API.Examples:
Screenshots
None
Any side note on the changes made
Improved also the Exception modeling of the Datastore services