-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend accountSelfEdit support in Configurations #3152
Extend accountSelfEdit support in Configurations #3152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @lorthirk,
I have checked this PR and it all looks fine except the message as commented bellow and this permission error. I think that it should be handled more gracefuly? What do you think?
.../src/main/java/org/eclipse/kapua/commons/configuration/AbstractKapuaConfigurableService.java
Outdated
Show resolved
Hide resolved
Well... In a way I agree with you, the error should be handled more gracefully. Anyway this is a general problem of how missing permissions are reported: you will get the same message if, let's say, you go change a setting in a child account for a service you only have a |
03132d2
to
67ae331
Compare
67ae331
to
21c69b3
Compare
de537a8
to
203e106
Compare
203e106
to
eb6cc38
Compare
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
eb6cc38
to
11a52e0
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3152 +/- ##
=============================================
- Coverage 63.03% 63.03% -0.01%
Complexity 2489 2489
=============================================
Files 1118 1118
Lines 23138 23145 +7
Branches 2000 2004 +4
=============================================
+ Hits 14586 14590 +4
+ Misses 7634 7633 -1
- Partials 918 922 +4
|
Extending support for
allowSelfEdit
in Service configurations. A field marked withallowSelfEdit="true"
in the Service Metadata XML can be edited by users of the account itself, not only from the parent account. As a first use case, all the configurations ofCredentialsService
are now self-editable.An user can edit its own
allowSelfEdit="true"
configurations in the "Settings" view of the console, or via REST API.Related Issue
No related issues