Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend accountSelfEdit support in Configurations #3152

Merged

Conversation

lorthirk
Copy link

Extending support for allowSelfEdit in Service configurations. A field marked with allowSelfEdit="true" in the Service Metadata XML can be edited by users of the account itself, not only from the parent account. As a first use case, all the configurations of CredentialsService are now self-editable.

An user can edit its own allowSelfEdit="true" configurations in the "Settings" view of the console, or via REST API.

Related Issue
No related issues

@lorthirk lorthirk added Console GWT This issue/PR is related to Admin Web Console Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday labels Nov 24, 2020
@lorthirk lorthirk requested a review from Coduz November 24, 2020 17:37
Copy link
Contributor

@LeoNerdoG LeoNerdoG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @lorthirk,
I have checked this PR and it all looks fine except the message as commented bellow and this permission error. I think that it should be handled more gracefuly? What do you think?

Screenshot 2020-11-25 at 07 46 13

@lorthirk
Copy link
Author

Well... In a way I agree with you, the error should be handled more gracefully. Anyway this is a general problem of how missing permissions are reported: you will get the same message if, let's say, you go change a setting in a child account for a service you only have a read permission. So I wouldn't link the issue to this PR, but rather open a new one for the specific case.

@lorthirk lorthirk force-pushed the feature-accountConfigurationSelfEdit branch from 03132d2 to 67ae331 Compare November 26, 2020 10:57
@Coduz Coduz force-pushed the feature-accountConfigurationSelfEdit branch from 67ae331 to 21c69b3 Compare November 29, 2020 09:53
@lorthirk lorthirk force-pushed the feature-accountConfigurationSelfEdit branch 4 times, most recently from de537a8 to 203e106 Compare December 1, 2020 11:44
@lorthirk lorthirk force-pushed the feature-accountConfigurationSelfEdit branch from 203e106 to eb6cc38 Compare December 9, 2020 09:16
Claudio Mezzasalma added 3 commits December 9, 2020 10:20
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the feature-accountConfigurationSelfEdit branch from eb6cc38 to 11a52e0 Compare December 9, 2020 09:21
@codecov
Copy link

codecov bot commented Dec 10, 2020

Codecov Report

Merging #3152 (11a52e0) into develop (83e33ea) will decrease coverage by 0.00%.
The diff coverage is 70.58%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3152      +/-   ##
=============================================
- Coverage      63.03%   63.03%   -0.01%     
  Complexity      2489     2489              
=============================================
  Files           1118     1118              
  Lines          23138    23145       +7     
  Branches        2000     2004       +4     
=============================================
+ Hits           14586    14590       +4     
+ Misses          7634     7633       -1     
- Partials         918      922       +4     
Impacted Files Coverage Δ Complexity Δ
...onfiguration/AbstractKapuaConfigurableService.java 73.20% <50.00%> (-5.57%) 0.00 <0.00> (ø)
...ne/queue/jbatch/QueuedJobExecutionServiceImpl.java 51.61% <100.00%> (ø) 8.00 <1.00> (ø)
...ernal/JobDeviceManagementOperationServiceImpl.java 56.75% <100.00%> (ø) 8.00 <1.00> (ø)
...ice/endpoint/internal/EndpointInfoServiceImpl.java 74.50% <100.00%> (ø) 18.00 <1.00> (ø)
...inition/internal/JobStepDefinitionServiceImpl.java 43.58% <100.00%> (ø) 7.00 <1.00> (ø)
.../service/job/step/internal/JobStepServiceImpl.java 76.92% <100.00%> (ø) 21.00 <1.00> (ø)
...ice/job/targets/internal/JobTargetServiceImpl.java 72.72% <100.00%> (ø) 12.00 <1.00> (ø)
...e/scheduler/trigger/quartz/TriggerServiceImpl.java 71.77% <100.00%> (ø) 32.00 <1.00> (ø)
.../engine/jbatch/exception/JobResumingException.java 0.00% <0.00%> (-50.00%) 0.00% <0.00%> (-1.00%)
...ob/engine/jbatch/exception/JobEngineException.java 33.33% <0.00%> (-33.34%) 1.00% <0.00%> (-1.00%)
... and 11 more

@Coduz Coduz merged commit e2ae855 into eclipse-kapua:develop Dec 11, 2020
@lorthirk lorthirk deleted the feature-accountConfigurationSelfEdit branch December 11, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Console GWT This issue/PR is related to Admin Web Console Enhancement This PR/Issue improves an part of Kapua REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants