Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced usage of ConfigurationPrinter in some classes #3223

Merged
merged 3 commits into from
Feb 12, 2021

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Feb 9, 2021

This PR introduces the usage of ConfigurationPrinter utility class to improve readability of the code and improve the component configuration in some classes.

Related Issue
None

Description of the solution adopted
Replaced invocation of Logger.info with a lot of \n\t with invocations to ConfigurationPrinter which embeds a lot of the formatting logics

Screenshots
None

Any side note on the changes made
Added try-with-resources in CamelKapuaDefaultRouter

@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Feb 9, 2021
@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #3223 (a35c3b1) into develop (64bc9cc) will decrease coverage by 0.73%.
The diff coverage is 73.91%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3223      +/-   ##
=============================================
- Coverage      57.31%   56.57%   -0.74%     
  Complexity      2678     2678              
=============================================
  Files           1273     1273              
  Lines          26995    26991       -4     
  Branches        2340     2339       -1     
=============================================
- Hits           15472    15270     -202     
- Misses         10597    10802     +205     
+ Partials         926      919       -7     
Impacted Files Coverage Δ Complexity Δ
...se/kapua/broker/core/router/EndPointContainer.java 71.42% <0.00%> (-28.58%) 0.00 <0.00> (ø)
...gin/sso/openid/provider/AbstractOpenIDService.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...h/client/rest/RestElasticsearchClientProvider.java 50.28% <63.63%> (-0.29%) 19.00 <0.00> (ø)
...mons/service/internal/cache/KapuaCacheManager.java 79.22% <90.00%> (+0.55%) 0.00 <0.00> (ø)
...ua/broker/core/router/CamelKapuaDefaultRouter.java 87.50% <100.00%> (+10.00%) 0.00 <0.00> (ø)
.../kapua/commons/liquibase/KapuaLiquibaseClient.java 87.23% <100.00%> (-0.14%) 0.00 <0.00> (ø)
...e/kapua/commons/util/log/ConfigurationPrinter.java 98.92% <100.00%> (+0.06%) 0.00 <0.00> (ø)
...ransport/TransportElasticsearchClientProvider.java 87.34% <100.00%> (-0.16%) 0.00 <0.00> (ø)
...lasticsearch/server/embedded/EsEmbeddedEngine.java 86.88% <100.00%> (-0.22%) 3.00 <0.00> (ø)
...client/transport/TransportElasticsearchClient.java 1.61% <0.00%> (-80.57%) 0.00% <0.00%> (ø%)
... and 7 more

@Coduz Coduz force-pushed the fix-configurationPrinterUsage branch from a0c6d3c to 58b2aa8 Compare February 9, 2021 11:06
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the fix-configurationPrinterUsage branch from 58b2aa8 to 635bdf8 Compare February 11, 2021 08:49
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the fix-configurationPrinterUsage branch from b4e870d to f4d2332 Compare February 11, 2021 11:06
@Coduz Coduz merged commit c2cd156 into eclipse-kapua:develop Feb 12, 2021
@Coduz Coduz deleted the fix-configurationPrinterUsage branch February 12, 2021 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant