Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CORS error for non-CORS requests #3329

Merged

Conversation

lorthirk
Copy link

Fix an error introduced after merging #3324 where a 500 error would return for non-CORS requests if token was expired

Related Issue
No related issues

@lorthirk lorthirk added Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday labels Jun 10, 2021
@lorthirk lorthirk requested a review from Coduz June 10, 2021 13:40
Signed-off-by: Claudio Mezzasalma <claudio.mezzasalma@eurotech.com>
@lorthirk lorthirk force-pushed the fix-corsTokenExpiredNonCors branch from 83f10e3 to f097fe3 Compare June 10, 2021 13:57
@codecov
Copy link

codecov bot commented Jun 10, 2021

Codecov Report

Merging #3329 (eada8cd) into develop (4c2e315) will decrease coverage by 2.65%.
The diff coverage is 0.00%.

❗ Current head eada8cd differs from pull request most recent head f097fe3. Consider uploading reports for the commit f097fe3 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #3329      +/-   ##
=============================================
- Coverage      25.76%   23.11%   -2.66%     
+ Complexity       651      427     -224     
=============================================
  Files           1488     1488              
  Lines          30083    30084       +1     
  Branches        2508     2508              
=============================================
- Hits            7751     6953     -798     
- Misses         21721    22580     +859     
+ Partials         611      551      -60     
Impacted Files Coverage Δ
.../kapua/app/api/core/filter/CORSResponseFilter.java 0.00% <0.00%> (ø)
...ipse/kapua/message/internal/MessageErrorCodes.java 0.00% <0.00%> (-100.00%) ⬇️
...kapua/transport/exception/TransportErrorCodes.java 0.00% <0.00%> (-100.00%) ⬇️
...engine/jbatch/driver/JbatchJobRunningStatuses.java 0.00% <0.00%> (-100.00%) ⬇️
...ne/queue/jbatch/QueuedJobExecutionCreatorImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...ssage/kura/app/notification/KuraNotifyMessage.java 0.00% <0.00%> (-100.00%) ⬇️
.../registry/event/internal/DeviceEventQueryImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...stry/event/internal/DeviceEventListResultImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...s/message/notification/KapuaNotifyMessageImpl.java 0.00% <0.00%> (-100.00%) ⬇️
...s/message/notification/KapuaNotifyPayloadImpl.java 0.00% <0.00%> (-100.00%) ⬇️
... and 145 more

@lorthirk lorthirk merged commit 869107e into eclipse-kapua:develop Jun 11, 2021
@lorthirk lorthirk deleted the fix-corsTokenExpiredNonCors branch June 11, 2021 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This is a bug or an unexpected behaviour. Fix it! REST API We hope to REST everyday
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants