Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored KapuaFileUtilsTest #3641

Merged

Conversation

Coduz
Copy link
Contributor

@Coduz Coduz commented Oct 25, 2022

This PR refactors KapuaFIleUtilsTest to make it better.

This is an integration of PR #3639

Related Issue
This PR integrates changes in #3639

Description of the solution adopted
Improved tests

Screenshots
None

Any side note on the changes made
None

@Coduz Coduz added the Test Test related stuff. It's a dirty job, but someone needs to do that! label Oct 25, 2022
@Coduz Coduz requested a review from stefanomorson October 25, 2022 14:53
Signed-off-by: Alberto Codutti <alberto.codutti@eurotech.com>
@Coduz Coduz force-pushed the chng-KapuaFileUtilsTestRefactoring branch from c87eb21 to 53b17a7 Compare October 25, 2022 14:55
@Coduz Coduz added the Enhancement This PR/Issue improves an part of Kapua label Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #3641 (384c309) into develop (a5600c1) will decrease coverage by 19.46%.
The diff coverage is n/a.

❗ Current head 384c309 differs from pull request most recent head 53b17a7. Consider uploading reports for the commit 53b17a7 to get more accurate results

Impacted file tree graph

@@              Coverage Diff               @@
##             develop    #3641       +/-   ##
==============================================
- Coverage      34.00%   14.53%   -19.47%     
+ Complexity       122        8      -114     
==============================================
  Files           1668     1668               
  Lines          31987    31987               
  Branches        2634     2634               
==============================================
- Hits           10877     4650     -6227     
- Misses         20552    26928     +6376     
+ Partials         558      409      -149     
Impacted Files Coverage Δ
...rc/main/java/org/eclipse/kapua/KapuaException.java 0.00% <0.00%> (-100.00%) ⬇️
...c/main/java/org/eclipse/kapua/KapuaErrorCodes.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/eclipse/kapua/commons/util/Payloads.java 0.00% <0.00%> (-100.00%) ⬇️
...in/java/org/eclipse/kapua/broker/BrokerDomain.java 0.00% <0.00%> (-100.00%) ⬇️
...java/org/eclipse/kapua/commons/util/ClassUtil.java 0.00% <0.00%> (-100.00%) ⬇️
...ain/java/org/eclipse/kapua/event/ServiceEvent.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/eclipse/kapua/broker/BrokerDomains.java 0.00% <0.00%> (-100.00%) ⬇️
...va/org/eclipse/kapua/commons/util/SystemUtils.java 0.00% <0.00%> (-100.00%) ⬇️
...n/java/org/eclipse/kapua/model/domain/Actions.java 0.00% <0.00%> (-100.00%) ⬇️
.../java/org/eclipse/kapua/message/KapuaPosition.java 0.00% <0.00%> (-100.00%) ⬇️
... and 693 more

@Coduz Coduz merged commit b93b7cb into eclipse-kapua:develop Oct 26, 2022
@Coduz Coduz deleted the chng-KapuaFileUtilsTestRefactoring branch October 26, 2022 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This PR/Issue improves an part of Kapua Test Test related stuff. It's a dirty job, but someone needs to do that!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant