Fix URL regex marking as invalid legal URL #3789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Some valid URL was considered illegal in the device packages tab. - Add the URL validation check even on the backend side
Codecov Report
@@ Coverage Diff @@
## develop #3789 +/- ##
==============================================
- Coverage 50.55% 23.16% -27.40%
Complexity 26 26
==============================================
Files 1866 1866
Lines 35284 35288 +4
Branches 2782 2782
==============================================
- Hits 17839 8173 -9666
- Misses 16527 26804 +10277
+ Partials 918 311 -607
|
Coduz
reviewed
Jun 9, 2023
| @@ -70,7 +69,7 @@ public enum FieldType { | |||
| ALPHANUMERIC("alphanumeric", "^[a-zA-Z0-9_]+$"), | |||
| NUMERIC("numeric", "^[+0-9.]+$"), | |||
| PACKAGE_VERSION("package_version", "^[a-zA-Z0-9.\\-\\_]*$"), | |||
| URL("url", "(http(s)?:\\/\\/.)?(www\\.)?[-a-zA-Z0-9@:%._\\+~#=]{2,256}\\.[a-z]{2,6}\\b([-a-zA-Z0-9@:%_\\+.~#?&//=]*)"); | |||
| URL("url", "^(https?:\\/\\/)?(www\\.)?[-a-zA-Z0-9@:%._\\+~#=//]{1,256}\\.[a-zA-Z0-9()//]{2,6}\\b(?:[-a-zA-Z0-9()@:%_\\+.~#?&\\/=]*)$"); | |||
There was a problem hiding this comment.
Isn't this making use of https mandatory?
There was a problem hiding this comment.
It's ok to have a URL without the https with this regex, in fact the first part of it have the trailing ? character (^(https?:\\/\\/)?).
Coduz
approved these changes
Jun 12, 2023
Coduz
added
Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief description of the PR.
Some valid URLs was considered illegal, for example the following:
http://172.16.0.2:1234/static/com.eurotech.opcua.driver_1.1.1.dp.This PR is to fix this issue.
Related Issue
This PR fixes #3788.
Description of the solution adopted
Change the regex in order to include more URLs.
Any side note on the changes made
Added also the validation check on the backend side, in order to avoid console parameter validation bypass.