@RestClient - the current @Target is wrong

[mkouba]

The current value is @Target({ElementType.CONSTRUCTOR, ElementType.FIELD, ElementType.METHOD}).

1. It's not possible to inject a rest client into a method or a constructor parameter (missing ElementType.PARAMETER).
2. It's not possible to define test mocks for rest client interfaces (missing ElementType.TYPE).

CDI qualifiers typically define the target as follows: @Target({METHOD, FIELD, PARAMETER, TYPE}). ElementType.CONSTRUCTOR is completely useless.

[mkouba]

This issue follows up on #232.

[andreas-eberle]

@mkouba: I created a PR to add the missing ElementType.PARAMETER. Besides that, I was wondering if ElementType.CONSTRUCTOR should be in that list.

[mkouba]

I believe that the correct value is @Target({METHOD, FIELD, PARAMETER, TYPE}), i.e. no ElementType.CONSTRUCTOR (qualifiers declared on a constructor are ignored) and add ElementType.TYPE.

[andreas-eberle]

@mkouba: Why do you think ElementType.TYPE should be added? Do you have an example?

[mkouba]

It could be useful when creating mocks:

@Path("/echo")
@RegisterRestClient
public interface EchoClient {

    @GET
    @Produces(MediaType.TEXT_PLAIN)
    @Consumes(MediaType.TEXT_PLAIN)
    String echo(@QueryParam("message") String message);
}

@Priority(1)
@Alternative // Takes precedence over the bean provided by the MP Rest Client impl
@RestClient
class MockEchoClient implements EchoClient {
    public String echo(String message) {
       return "mock!";
   }
}

[andreas-eberle]

Good idea. I added it to my PR. Thanks for the input!