Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

question: should the search response include the downloadUrl as part of 'allVersions' #149

Closed
vince-fugnitto opened this issue Jul 20, 2020 · 1 comment
Assignees
Labels
server Component: server

Comments

@vince-fugnitto
Copy link
Member

Description

The search API response now includes an updated allVersions object which contains information regarding all versions of an extension and their corresponding engines fields. I noticed that part of this object we include the url which points to the api but I was wondering should we not instead/or in addition to include the download url? Is the idea that clients will need to perform an additional request to obtain the proper download url once they determine a compatible extension? Perhaps it'd be more useful to include the download url instead so this extra request is not necessary.

For example: https://open-vsx.org/api/-/search?query=prettier

"allVersions":[
  {
    "url":"https://open-vsx.org/api/esbenp/prettier-vscode/5.1.3",
    "version":"5.1.3",
    "engines":{
      "vscode":"^1.41.0"
    }
  },
  {
    "url":"https://open-vsx.org/api/esbenp/prettier-vscode/5.1.0",
    "version":"5.1.0",
     "engines":{
       "vscode":"^1.41.0"
     }
  }
]
@spoenemann spoenemann added the server Component: server label Jul 21, 2020
@spoenemann
Copy link
Member

We can add the download URL in addition to the metadata URL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
server Component: server
Projects
None yet
Development

No branches or pull requests

2 participants