Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Considering NO_PROXY environment variable on Proxy Settings #1473

Open
emrahayanoglu opened this issue Apr 23, 2024 · 2 comments
Open

Considering NO_PROXY environment variable on Proxy Settings #1473

emrahayanoglu opened this issue Apr 23, 2024 · 2 comments
Milestone

Comments

@emrahayanoglu
Copy link

Is your feature request related to a problem? Please describe.
Currently, if we don't set any http/https proxy on the MQTT Client Options, related http and https proxy settings are taken from the environment variables, which de-facto standard environment variables as presented in the nice article from Gitlab guys: https://about.gitlab.com/blog/2021/01/27/we-need-to-talk-no-proxy/
However, as current library is not considering NO_PROXY environment variable on our client settings, which basically leads to introducing additional logic or special docker configurations on our development or testing environments.

Describe the solution you'd like
Right thing is to consider also NO_PROXY environment variable on proxy settings of the MQTT Client Options, where if endpoint is in the list of the NO_PROXY, proxy settings will be ignored automatically.

@icraggs
Copy link
Contributor

icraggs commented Apr 25, 2024

I think this is a duplicate of #1329

@icraggs icraggs added this to the 1.3.14 milestone Apr 25, 2024
@emrahayanoglu
Copy link
Author

emrahayanoglu commented Jun 11, 2024

@icraggs correct it is absolutely same problem what we experienced.
I also go for closing the ticket.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants