Null pointer access if the server URI does not contain a ':'

[jpwsutton]

migrated from Bugzilla #484386
status UNCONFIRMED severity normal in component MQTT-C for 1.2
Reported in version 1.2 on platform PC
Assigned to: Ian Craggs

Original attachment names and IDs:

• commit-ff8cd5b (ID 258686)

On 2015-12-15 07:43:27 -0500, Juergen Kosel wrote:

Created attachment 258686
Patch to fix this issue

If the user accidentally provided a bad server URI without port and without ':'
the paho-mqtt library crashes due to null pointer access.
The fix is simple, please look at the attached patch.

[icraggs]

For this bug, I think we should be ensuring that the port is specified. There is no default port assignment in the API, so not specifying the port in the serverURI is going to fail anyway. With this approach, creating a client without specifying the port will fail with, perhaps with a new -10 return code (BAD_SERVERURI).

[JuergenKosel]

A default port is assigned in file MQTTProtocollOut.c function MQTTProtocol_addressPort().
So it should be okay to not especially specify a port.

[icraggs]

This was fixed in the fix for issue #7 and works in the develop branch.