Cache the build timestamp #1424
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #669, some functions use the
BUILD_TIMESTAMPmacro which is created in theCMakeLists.txtand set to the current time. This causes a recompilation of the corresponding source files with every rebuild. When using Paho as a submodule in a project, it can consequently also trigger relinking of (parts of) the whole project, even with no changes. Of course, this makes developing quite annoying.This PR caches the timestamp of the first build of Paho and subsequently reuses that same value, which removes the need to recompile. Clean builds (including CI and package builds) are not affected.