Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker environment #7

Merged
merged 5 commits into from
Oct 17, 2018
Merged

Fix docker environment #7

merged 5 commits into from
Oct 17, 2018

Conversation

Naramsim
Copy link
Member

@Naramsim Naramsim commented Oct 16, 2018

This PR:

Tested on Win10 noWSL - Docker version 18.01.0-ce, build 03596f5

@Naramsim Naramsim added bug Something isn't working windows Microsoft Windows related docker Docker related labels Oct 16, 2018
@Naramsim Naramsim requested a review from serenaponta October 16, 2018 17:17
@CLAassistant
Copy link

CLAassistant commented Oct 16, 2018

CLA assistant check
All committers have signed the CLA.

@Naramsim Naramsim requested a review from henrikplate October 16, 2018 17:23
@serenaponta
Copy link
Contributor

serenaponta commented Oct 17, 2018

After merging the PR, please also add the information about the systems we used to test it in docker/README.md

@Naramsim Naramsim merged commit 5206bb3 into master Oct 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working docker Docker related windows Microsoft Windows related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants