Skip Tycho dependency resolution for clean-only builds by default #166
Comments
|
Tycho somehow modifies the Maven model by adding dependencies, but AFAIK,it does affect the typical "dirty" directories that clean is supposed to process. So ok, let's try it! |
You meant Because yes, the modifications of the Maven-model performed by Tycho in I'm about to open a PR to address this. |
…ilds by default Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
…ilds by default Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case. Change-Id: I68b7abf61835665a648a0bc006153c4631b56ff8 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
…ion from eclipse-tycho#166) If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case. Change-Id: I68b7abf61835665a648a0bc006153c4631b56ff8 Signed-off-by: Hannes Wellmann <wellmann.hannes1@gmx.net>
…ion from eclipse-tycho#166) If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case.
If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case.
If default goals are used Maven can be invoked without specifying goals explicitly in the command, so the List of goals is empty. This had the consequence, that the AbstractMavenLifecycleParticipant false detected a clean-only build and skipped dependency/target-platform resolution, which lead to follow up errors. The logic to detect 'clean-only' builds is improved to consider the described case.
When you want to clean Eclipse projects build with Maven/Tycho the dependency resolution is performed initially by default, even tough it is not necessary (please correct me if I'm wrong). For large projects the dependency resolution takes the vast majority of runtime in a
clean-only build.In order to speed-up
cleanbuilds, one can specify the property-Dtycho.mode=mavento skip the dependency resolution.For convenience (on the command-line and in the IDE) and to speed up cleans for users that do not know about the mentioned property I suggest to skip the dependency resolution by default for clean only builds.
This could be accomplished in
TychoMavenLifecycleParticipant.disableLifecycleParticipation(Seesion)by checking if the session only has the goal"clean".If nothing else speaks against it, I can provide a patch to change that default behavior for clean-only builds.
The text was updated successfully, but these errors were encountered: