Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.0-alpha.0 Performance Rendering React #1407

Closed
Lily418 opened this issue Jun 17, 2019 · 4 comments
Closed

v2.3.0-alpha.0 Performance Rendering React #1407

Lily418 opened this issue Jun 17, 2019 · 4 comments
Labels
Milestone

Comments

@Lily418
Copy link
Contributor

Lily418 commented Jun 17, 2019

Describe the bug
Between v2.2.3 and v2.3.0-alpha.0 speed of rendering has decreased

To Reproduce
Steps to reproduce the behavior:

  1. Running the Material Package Examples
  2. Choose "Huge Test" example
  3. Observe that in v2.3.0-alpha.0 when typing in a field takes ~0.5s to render, v2.2.3 is noticable faster to render

Browser (please complete the following information):

  • Browser Firefox
  • Version 67.0.2

Used Setup (please complete the following information):

  • Framework:React
  • RendererSet: Material

Additional context
I'm going to run the React Profiler to see if I can determine the cause

@Lily418
Copy link
Contributor Author

Lily418 commented Jun 17, 2019

Ah looks like #1406 is about this

@edgarmueller
Copy link
Contributor

Yes, indeed, we noticed that performance degrade as well and working on it. Thanks for report.

@edgarmueller edgarmueller added this to the 2.3.0 milestone Jun 17, 2019
@edgarmueller
Copy link
Contributor

This should be fixed via #1406. If you experience significant slow-downs related to the context-based API, please re-open.

@georgiosd
Copy link

Is this still an issue @edgarmueller? Editing a text item in a nested array causes tons of re-renders as shown below.

Screenshot 2020-09-22 at 1 10 07 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants