Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialRadioGroupControl not used #1601

Closed
TheZoker opened this issue Jul 2, 2020 · 1 comment · Fixed by #1642
Closed

MaterialRadioGroupControl not used #1601

TheZoker opened this issue Jul 2, 2020 · 1 comment · Fixed by #1642
Assignees

Comments

@TheZoker
Copy link
Contributor

TheZoker commented Jul 2, 2020

Describe the bug

MaterialRadioGroupControl not used. Instead MaterialEnumControl is used

To Reproduce

Steps to reproduce the behavior:

  1. Use following schema:
export const schema = {
  type: 'object',
  properties: {
    exampleRadioEnum: {
      type: 'string',
      enum: ['One', 'Two', 'Three']
    }
  }
};
  1. Use following uischema
export const uischema = {
  type: 'Control',
  scope: '#/properties/exampleRadioEnum',
  options: {
    format: 'radio'
  }
},

Expected behavior

Use MaterialRadioGroupControl when option format: 'radio' is applied

Screenshots
none

Browser (please complete the following information):

  • Browser: chrome
  • Version: 83

Used Setup (please complete the following information):

  • Framework: react
  • RendererSet: material

Additional context
none

@sdirix
Copy link
Member

sdirix commented Sep 29, 2020

ToDo:

  • Increase ranking of tester
  • Make sure it only applies to enums with format radio
  • Add radio example to example app if it doesn't exist yet
  • Test whether it works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants