-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Angular 12 compatibility #1761
Comments
Hi @sdirix, I saw you created #1762, which resolves the webpack 5 problem, but it looks like a braking change. Since I currently evaluate my options, to integrate jsonforms in a existing Angular 12 app, can you please give me any info about the plans for releasing this change. Should this be part of the 3.0 release? If so, do you plan to put prereleases on npm soon? |
Hi @StefanSchoof, first, thank you for the report. As you noticed, the cause of the reported issue lies in the #1762 should fix the error presented here. While it's a (minor) breaking change, it's only one for the React Material renderers. The Angular renderers never used this functionality anyway. So besides the error going away, you shouldn't notice any difference. For the final 3.0 release we plan to integrate more changes. However as soon as #1762 is merged we'll definitely do an 3.0 alpha prerelease which can be consumed by you. |
Thanks, @sdirix for the quick explanation. Then I will try to get my forms to fly. |
Hi @StefanSchoof, JSON Forms |
Thanks, I found today time to look into it and it is working. |
Describe the bug
A clear and concise description of what the bug is.
To Reproduce
Steps to reproduce the behavior:
git clone https://github.com/eclipsesource/jsonforms-angular-seed.git
cd jsonforms-angular-seed
ng update @angular/core@12 @angular/cli@12
× Migration failed: Incompatible peer dependencies found.
Peer dependency warnings when installing dependencies means that those dependencies might not work correctly together.
You can use the '--force' option to ignore incompatible peer dependencies and instead address these warnings later."
ng update @angular/core@12 @angular/cli@12 --force
(works without an error)npm start
Expected behavior
jsonforms is working with latest released angular version
Screenshots
n/a
Browser (please complete the following information):
n/a
Used Setup (please complete the following information):
Additional context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: