Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSONForms >= 3.0.0 is incompatible with @mui/x-date-pickers >= 6.0.0 #2137

Closed
sebastianfrey opened this issue May 10, 2023 · 2 comments · Fixed by #2139
Closed

JSONForms >= 3.0.0 is incompatible with @mui/x-date-pickers >= 6.0.0 #2137

sebastianfrey opened this issue May 10, 2023 · 2 comments · Fixed by #2139
Labels
bug dependencies Pull requests that update a dependency file material react
Milestone

Comments

@sebastianfrey
Copy link
Contributor

Describe the bug

JSONForms >= 3.0.0 crashes when used with @mui/x-date-pickers >= 6.0.0.

Expected behavior

JSONForms >= 3.0.0 should not crash when used with @mui/x-date-pickers >= 6.0.0.

Steps to reproduce the issue

  1. Go to https://codesandbox.io/s/jsonforms-with-v6-mui-date-pickers-b8mkzm
  2. Click on DatePicker calendar button
  3. See error

Screenshots

No response

In which browser are you experiencing the issue?

Google Chrome 113.0.5672.92 (Official Build) (64-bit)

Which Version of JSON Forms are you using?

v3.0.0

Framework

React

RendererSet

Material

Additional context

No response

@sdirix
Copy link
Member

sdirix commented May 12, 2023

Hi @sebastianfrey,

At the moment we build against ^5.0.0-beta.5.

Would you like to contribute an upgrade to ^6.0.0. If somehow possible it would be great to keep compatibility with ^5.0.0 but if it doesn't work then that's life.

@sdirix sdirix added bug react material dependencies Pull requests that update a dependency file labels May 12, 2023
@sdirix sdirix added this to the 3.x milestone May 12, 2023
@sebastianfrey
Copy link
Contributor Author

Hi @sdirix,

Sure, I can submit a PR which upgrades @mui/x-date-pickers to v6.0.0.

What I can't guarantee is backwards compatibility to v5.0.0. The reason for that is, that there are a lot of breaking changes from v5 to v6.

Side note:

Those guys from MUI rush very fast forward and do not care a lot about backwards compatibility. From experience I can say that I have already experienced this several times on my own skin. So have you I guess.

As mentioned in their v6 release article, they will decouple the versioning of MUI-X packages from MUI-Core, so they can move forward a lot faster, because it allows them to introduce breaking changes easier.

Having this in mind, it might be a good idea to separate the MUI-X related material renderers into separate packages. That would allow JSONForms to support multiple @mui/x-date-pickers versions at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug dependencies Pull requests that update a dependency file material react
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants