Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[react] Only set resolving flag if new schemas has refs in JsonFors c… #1310

Merged
merged 1 commit into from
Mar 22, 2019
Merged

[react] Only set resolving flag if new schemas has refs in JsonFors c… #1310

merged 1 commit into from
Mar 22, 2019

Conversation

edgarmueller
Copy link
Contributor

…omponent

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 89.116% when pulling 31f6e12 on edgarmueller:feat/only-resolve-if-refs into 4e7d193 on eclipsesource:master.

sdirix
sdirix approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@edgarmueller edgarmueller merged commit f2409dc into eclipsesource:master Mar 22, 2019
@edgarmueller edgarmueller added this to the 2.2.2 milestone Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdirix sdirix sdirix approved these changes

@eneufeld eneufeld Awaiting requested review from eneufeld

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@edgarmueller @coveralls @sdirix