Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Angular] Initial Table #1369

Merged
merged 3 commits into from
Jun 18, 2019
Merged

[Angular] Initial Table #1369

merged 3 commits into from
Jun 18, 2019

Conversation

eneufeld
Copy link
Member

No description provided.

@coveralls
Copy link

coveralls commented May 14, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.3%) to 84.59% when pulling 644e7ff on eneufeld:feat/angular_table into 2abb9c7 on eclipsesource:master.

edgarmueller
edgarmueller suggested changes May 15, 2019
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good, but there are a couple of minor issues that should be fixed. I also think we should a minimal padding between columns, see attached screenshot.

angular_table_missing_padding

packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Outdated Show resolved Hide resolved
packages/angular-material/test/table-control.spec.ts Outdated Show resolved Hide resolved
packages/angular-material/test/table-control.spec.ts Outdated Show resolved Hide resolved
packages/angular-material/src/other/table.renderer.ts Show resolved Hide resolved
@eneufeld
Copy link
Member Author

I didn't manage to add a padding, the examples don't show an example with padding, I will try to add a custom css see https://material.angular.io/components/table/overview

@edgarmueller edgarmueller added this to the 2.3.0 milestone May 17, 2019
@edgarmueller edgarmueller merged commit 5ecd9da into eclipsesource:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarmueller edgarmueller edgarmueller approved these changes

Assignees
No one assigned
Labels
angular
Projects
None yet
Milestone
2.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@eneufeld @coveralls @edgarmueller