Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies & tests #1431

Merged

Conversation

edgarmueller
Copy link
Contributor

Update ava together with other dev deps in order to fix security related warnings.
The ava update involves a bit of refactoring as the API changed slightly.

Update ava together with other dev deps in order to
fix security related warnings.
The ava update involves a bit of refactoring
as the API changed slightly.
@edgarmueller edgarmueller added this to the 2.3.0 milestone Jul 11, 2019
@edgarmueller edgarmueller self-assigned this Jul 11, 2019
@coveralls
Copy link

coveralls commented Jul 11, 2019

Coverage Status

Coverage increased (+0.06%) to 82.34% when pulling 74adf38 on edgarmueller:fix/update-dependencies into 14407fd on eclipsesource:master.

@edgarmueller edgarmueller changed the title Update dev dependencies Update dependencies & tests Jul 12, 2019
@edgarmueller edgarmueller requested a review from sdirix July 14, 2019 10:02
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good to me, however I can't check every detail with such a huge change. JSONForms builds, tests and runs fine locally for me. Check my comments for remarks.

Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly still some header changes in there

packages/vanilla/test/renderers/GroupLayout.test.tsx Outdated Show resolved Hide resolved
Replace usage of currentTarget with target in vanilla controls.
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks for the changes!

@edgarmueller edgarmueller merged commit 0037474 into eclipsesource:master Jul 16, 2019
edgarmueller added a commit to edgarmueller/jsonforms that referenced this pull request Jul 17, 2019
Update `ava` together with other dev deps in order to fix security related warnings.
The ava update involves a bit of refactoring as the API changed slightly.
Vanilla tests have been ported to `enzyme` as code coverage via `nyc` broke.
Vanilla controler now use `target` instead of `currentTarget` in their respective event handler
The required lines coverage in core has been decreased (related to eclipsesource#1420)
Update travis config to be based on node 6.x

This should fix some of the issues raised by eclipsesource#1423 - eclipsesource#1428.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants