-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies & tests #1431
Update dependencies & tests #1431
Conversation
Update ava together with other dev deps in order to fix security related warnings. The ava update involves a bit of refactoring as the API changed slightly.
eb9c0bb
to
2464fa2
Compare
df0b795
to
aba629a
Compare
e5ce1cb
to
1815ebd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly good to me, however I can't check every detail with such a huge change. JSONForms builds, tests and runs fine locally for me. Check my comments for remarks.
1815ebd
to
abb009f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sadly still some header changes in there
Replace usage of currentTarget with target in vanilla controls.
abb009f
to
74adf38
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! Thanks for the changes!
Update `ava` together with other dev deps in order to fix security related warnings. The ava update involves a bit of refactoring as the API changed slightly. Vanilla tests have been ported to `enzyme` as code coverage via `nyc` broke. Vanilla controler now use `target` instead of `currentTarget` in their respective event handler The required lines coverage in core has been decreased (related to eclipsesource#1420) Update travis config to be based on node 6.x This should fix some of the issues raised by eclipsesource#1423 - eclipsesource#1428.
Update ava together with other dev deps in order to fix security related warnings.
The ava update involves a bit of refactoring as the API changed slightly.