Fix performance issues #1439
Merged
Fix performance issues #1439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract ExpandPanelRenderer into own file for maintenance reasons. Remove usage of `useJsonForms` within renderer and replace with HOCs analogously to existing renderers. Partly fixes eclipsesource#1433
Remove usage of ctxToLayoutProps in categorization layout, replace with HOC. Partly fixes eclipsesource#1433
eneufeld
approved these changes
Jul 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the problems identified in #1433
Extracted
ExpandPanelRendererinto its own file and replace usage of context within renderer. Instead provide HOC that extract the props accordingly.Remove usage of context consumer in categorization layout renderer and replace with usage of HOC as well. Adapted tests.