Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent use of config #1465

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Consistent use of config #1465

merged 1 commit into from
Aug 12, 2019

Conversation

sdirix
Copy link
Member

@sdirix sdirix commented Jul 30, 2019

Fixes #1462

@coveralls
Copy link

coveralls commented Jul 30, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.3%) to 83.527% when pulling 53a14f2 on sdirix:consistent-config into f048364 on eclipsesource:master.

@edgarmueller edgarmueller self-requested a review July 31, 2019 09:46
@sdirix sdirix marked this pull request as ready for review August 6, 2019 11:39
@sdirix
Copy link
Member Author

sdirix commented Aug 7, 2019

@edgarmueller Please recheck the changes. There were a lot of additional changes needed because of changes merged in the mean time.

edgarmueller
edgarmueller approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@edgarmueller edgarmueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@edgarmueller edgarmueller merged commit 689b789 into eclipsesource:master Aug 12, 2019
@edgarmueller edgarmueller mentioned this pull request Aug 12, 2019
Open
@edgarmueller
Copy link
Contributor

Created a follow-up issue for possible improvments here: #1472

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarmueller edgarmueller edgarmueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read property 'showUnfocusedDescription' of undefined
3 participants
@sdirix @coveralls @edgarmueller