Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve feedback during message move #350

Open
planger opened this issue Sep 12, 2018 · 1 comment
Open

Improve feedback during message move #350

planger opened this issue Sep 12, 2018 · 1 comment
Labels
visual_feedbacks Requirements related to the visual feedback provided during edit actions

Comments

@planger
Copy link
Collaborator

planger commented Sep 12, 2018

There is an issue in the visual feed-back during message move remaining stuck at the start or finish of an execution specification. A naïve fix that lets execution specifications have left- or right-side anchors with negative values or values greater than the length of the execution fixes that problem, but doesn't really make sense and breaks a JUnit test for create messages. So, we need to work on letting the FeedbackHelper change not just anchor identity but also the connected node figure at each end, which determines the kind of anchor.

@planger planger added this to the M2 - Move and reordering ES1 milestone Nov 15, 2018
@planger planger added the visual_feedbacks Requirements related to the visual feedback provided during edit actions label Dec 13, 2018
@rschnekenbu
Copy link
Collaborator

Feedback of messages has been greetly improved with PR #449.
However, integrating the figure of the execution in the feedback is an extensive task (See MessageFeedbackHelper class). As time was short, I prefered to avoid regressions on the current implementation.
Moving to Milestone 3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
visual_feedbacks Requirements related to the visual feedback provided during edit actions
Projects
None yet
Development

No branches or pull requests

2 participants