Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntryVisititor should use a unique_ptr<Store> instead of a raw pointer #61

Open
Ozaq opened this issue Dec 11, 2024 · 0 comments
Open

Comments

@Ozaq
Copy link
Contributor

Ozaq commented Dec 11, 2024

EntryVisitor now uses an owned Store pointer. Coincidentally this pointer is released from a unique_ptr. However when just changing the code to use a unique_ptr I ran into circular dependencies between our headers, as I can no longer rely on a forward declaration when using a unique_ptr.

This is probably a bit of a pain to address but could help a lot with our code organization.

... this should be a unique_ptr as it is even initialized from the release of a unique_ptr in EntryVisitor.cc:46

Originally posted by @Ozaq in #54 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant