Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frame shifting: do not use currently selected frequencies #144

Closed
kdarras opened this issue Nov 11, 2021 · 3 comments
Closed

Frame shifting: do not use currently selected frequencies #144

kdarras opened this issue Nov 11, 2021 · 3 comments
Assignees
@LiuDilongNJ
Labels
adjustment small change needed good first issue Good for newcomers

Comments

@kdarras
Copy link

kdarras commented Nov 11, 2021 •
edited
Loading

Currently, when a selection is made and the frame is shifted with the left and right arrow buttons, if a selection is currently made, the frame will shift and zoom to the frequency range that is selected. This is confusing for users.
Also when no zooming is done, the frame shifting buttons will do something - also confusing.

Frame shifting should only shift the frame in time relative to the current view (independently of the current selection), and should be disabled when not zoomed-in.
@kdarras kdarras added the adjustment small change needed label Nov 11, 2021
@kdarras kdarras added this to Player Jul 15, 2022
@kdarras kdarras moved this to Todo in Player Jul 15, 2022
@kdarras kdarras added the good first issue Good for newcomers label Nov 28, 2022
LiuDilongNJ pushed a commit that referenced this issue Aug 13, 2024
issues #144 #382
4e8b1cc
@kdarras kdarras mentioned this issue Aug 14, 2024
Open
@kdarras
Copy link
Author

kdarras commented Aug 14, 2024

working in Docker
created #490

@kdarras
Copy link
Author

kdarras commented Aug 30, 2024

working online

@kdarras
Copy link
Author

kdarras commented Sep 18, 2024

completed in #511

@kdarras kdarras closed this as completed Sep 18, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Player Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LiuDilongNJ LiuDilongNJ

Labels
adjustment small change needed good first issue Good for newcomers
Projects
Player
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kdarras @LiuDilongNJ