Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audio recording gain #257

Closed
kdarras opened this issue Oct 21, 2022 · 7 comments
Closed

audio recording gain #257

kdarras opened this issue Oct 21, 2022 · 7 comments
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@kdarras
Copy link

kdarras commented Oct 21, 2022

Audio recording amplification settings affect the measured sound levels (#241 ). This field should be called "recording_gain" needs to be added to the recording table and it can only contain positive integers (dB). Later, we may have an additional "added_gain" field for post-recording gain.

Users must indicate audio recording gain settings during recording upload inside the form. The meta-data may contain this information so it might be automatically extracted from there (#424 ).

@kdarras kdarras added the enhancement New feature or request label Oct 21, 2022
@kdarras kdarras changed the title audio recording gain setting audio recording gain and filter setting Nov 14, 2022
@kdarras kdarras moved this to To do in Sound analysis Dec 11, 2023
@kdarras kdarras changed the title audio recording gain and filter setting audio recording gain Feb 1, 2024
@kdarras kdarras added this to the F1000 v3 milestone Aug 15, 2024
@kdarras
Copy link
Author

kdarras commented Aug 23, 2024

Changing the date for a previously-entered meta-data row resulted in an error:
Screenshot from 2024-08-23 13-28-57
To avoid that edits of any pre-existing recording table rows results in this error, the easiest fix might be that we make this a non-required field (i.e., accepting NULL values).

@kdarras kdarras linked a pull request Aug 26, 2024 that will close this issue
@kdarras
Copy link
Author

kdarras commented Aug 30, 2024

Recording table field headers are shifted relative to their columns before upload is finished:
image

@kdarras
Copy link
Author

kdarras commented Aug 30, 2024

I also managed to input a negative value without error:
image
This should not be allowed as gain can only be a positive integer.

@kdarras
Copy link
Author

kdarras commented Sep 11, 2024

Sorry, ¨0¨ should also be allowed. Gain just cannot be negative.

@kdarras
Copy link
Author

kdarras commented Sep 16, 2024

Only positive values are inserted. Zeroes are currently ignored. Zero values should be inserted.

@kdarras
Copy link
Author

kdarras commented Sep 16, 2024

fixed and working online

@kdarras
Copy link
Author

kdarras commented Sep 18, 2024

completed in #511

@kdarras kdarras closed this as completed Sep 18, 2024
@github-project-automation github-project-automation bot moved this from To do to Done in Sound analysis Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants