-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ecodiv techno #511
Ecodiv techno #511
Conversation
…d-upload' into Batch-acoustic-index-analysis-and-upload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've installed the new branch and it works well.
I'm actually not sure how you manage the db changes on the production system. Are there any migration techniques?
@@ -118,6 +122,7 @@ CREATE TABLE `file_upload` | |||
`rating` enum('A','B','C','D','E') COLLATE utf8_unicode_ci DEFAULT NULL, | |||
`type` varchar(50) COLLATE utf8_unicode_ci DEFAULT NULL, | |||
`medium` varchar(50) COLLATE utf8_unicode_ci DEFAULT NULL, | |||
`recording_gain` int(11) DEFAULT NULL, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The recording gain has to be added when I upload the sound file!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so, the default here is NULL but on production we require a gain value... does this file's code need to be updated @LiuDilongNJ ?
'message' => 'Recording gain must be a positive integer.', | ||
]); | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the code where the recording gain has to be set as positive integer!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK I corrected this, thanks. Please check @LiuDilongNJ
corrected gain value check and message
I put a restriction on the recording_gain field on the server side so that it doesn't appear to be null. Since we didn't have a recording_gain before, and the recording_gain of the previous recording wasn't always 0, I kept the null case. |
No description provided.