Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ecodiv techno #511

Merged
merged 36 commits into from
Sep 18, 2024
Merged

Ecodiv techno #511

merged 36 commits into from
Sep 18, 2024

Conversation

LiuDilongNJ
Copy link
Collaborator

No description provided.

Copy link
Collaborator

@shofstet shofstet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've installed the new branch and it works well.
I'm actually not sure how you manage the db changes on the production system. Are there any migration techniques?

@@ -118,6 +122,7 @@ CREATE TABLE `file_upload`
`rating` enum('A','B','C','D','E') COLLATE utf8_unicode_ci DEFAULT NULL,
`type` varchar(50) COLLATE utf8_unicode_ci DEFAULT NULL,
`medium` varchar(50) COLLATE utf8_unicode_ci DEFAULT NULL,
`recording_gain` int(11) DEFAULT NULL,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The recording gain has to be added when I upload the sound file!

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so, the default here is NULL but on production we require a gain value... does this file's code need to be updated @LiuDilongNJ ?

'message' => 'Recording gain must be a positive integer.',
]);
}

Copy link
Collaborator

@shofstet shofstet Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the code where the recording gain has to be set as positive integer!

Copy link

@kdarras kdarras Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK I corrected this, thanks. Please check @LiuDilongNJ

kdarras and others added 2 commits September 17, 2024 16:42
@LiuDilongNJ
Copy link
Collaborator Author

I put a restriction on the recording_gain field on the server side so that it doesn't appear to be null. Since we didn't have a recording_gain before, and the recording_gain of the previous recording wasn't always 0, I kept the null case.
The production database is deployed using the structural synchronisation feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants