Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How can I add a FileSet to a FileSet? #52

Open
RasmusGOlsen opened this issue Jul 28, 2023 · 2 comments · May be fixed by #54
Open

How can I add a FileSet to a FileSet? #52

RasmusGOlsen opened this issue Jul 28, 2023 · 2 comments · May be fixed by #54
Labels
Bug Something isn't working Enhancement New feature or request Question Further information is requested

Comments

@RasmusGOlsen
Copy link

It seems like the FileSet class is missing a function to add a FileSet to the private variable _fileSets. Furthermore, what is the thought behind declaring _fileSets as a dict and not a list?

@Paebbels Paebbels added Bug Something isn't working Enhancement New feature or request Question Further information is requested labels Jul 29, 2023
@Paebbels
Copy link
Member

Oh you're right. A file and a sequence of files can be added, but no fileset.

I'll fix that. It's a bug.


Fileset have names. The dictionary is to lookup a sub-filesets by name.

@Paebbels
Copy link
Member

There will be:

  • fileSet.AddFileSet(subFileSet)
  • fileSet.AddFileSets(subFileSets)

Anything else missing like that?


As a temporary workaround, there is currently the other way around:

  • subFileSet.Parent = fileSet

@Paebbels Paebbels linked a pull request Jul 29, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Enhancement New feature or request Question Further information is requested
Development

Successfully merging a pull request may close this issue.

2 participants