Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webapp, hapi): add election date to bar chart #310

Merged
merged 2 commits into from
Dec 9, 2022
Merged

feat(webapp, hapi): add election date to bar chart #310

merged 2 commits into from
Dec 9, 2022

Conversation

JAMares
Copy link
Contributor

@JAMares JAMares commented Dec 9, 2022

Add election date to bar chart

What does this PR do?

Steps to test

  1. Run Project
  2. Enter to Income or Expense
  3. Position pointer hover a election, must see this:
    imagen

CheckList

  • Follow proper Markdown format
  • The content is adequate
  • The content is available in both english and spanish
  • I Ran a spell check

@JAMares JAMares added WIP Work In Progress backend frontend Webapp Develop labels Dec 9, 2022
@JAMares JAMares self-assigned this Dec 9, 2022
@JAMares JAMares linked an issue Dec 9, 2022 that may be closed by this pull request
Election date isn't shown #302
Closed
@JAMares JAMares removed the WIP Work In Progress label Dec 9, 2022
warnerHurtado
warnerHurtado approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@warnerHurtado warnerHurtado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

xavier506
xavier506 approved these changes Dec 9, 2022
View reviewed changes
Copy link
Contributor

@xavier506 xavier506 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xavier506 xavier506 merged commit b83b244 into main Dec 9, 2022
@xavier506 xavier506 deleted the feat/election-date-isnt-shown-302 branch December 9, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@warnerHurtado warnerHurtado warnerHurtado approved these changes

@xavier506 xavier506 xavier506 approved these changes

@tetogomez tetogomez Awaiting requested review from tetogomez

@AngeloCG97 AngeloCG97 Awaiting requested review from AngeloCG97

@maemultichain maemultichain Awaiting requested review from maemultichain

Assignees

@JAMares JAMares

Labels
backend frontend Webapp Develop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Election date isn't shown
3 participants
@JAMares @xavier506 @warnerHurtado