Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: exec tty support #335

Closed
azenla opened this issue Aug 14, 2024 · 3 comments · Fixed by #334
Closed

feature: exec tty support #335

azenla opened this issue Aug 14, 2024 · 3 comments · Fixed by #334
Assignees
Labels
enhancement New feature or request

Comments

@azenla
Copy link
Member

azenla commented Aug 14, 2024

Right now, exec doesn't implement tty support. We should implement a tty flag and pass that through the stack, and let the exec handler allocate a tty.

@azenla azenla added the enhancement New feature or request label Aug 14, 2024
@azenla azenla self-assigned this Aug 14, 2024
@jedsalazar
Copy link
Contributor

jedsalazar commented Aug 14, 2024

Not sure if I should put this here but I'm seeing terminal weirdness with attach, even after a reset

demo@bronze:~$ kubectl attach -it privileged
If you don't see a command prompt, try pressing enter.
^@
# ^@
# ^@
# ^@g^@r^@e^@p^@ ^@C^@a^@p^@ ^@/^@p^@r^@o^@c^@/^@1

The above is the output of

grep Cap /proc/1/

@azenla
Copy link
Member Author

azenla commented Aug 14, 2024

Not sure if I should put this here but I'm seeing terminal weirdness with attach, even after a reset

demo@bronze:~$ kubectl attach -it privileged
If you don't see a command prompt, try pressing enter.
^@
# ^@
# ^@
# ^@g^@r^@e^@p^@ ^@C^@a^@p^@ ^@/^@p^@r^@o^@c^@/^@1

The above is the output of

grep Cap /proc/1/

Hmm, I think this is due to terminal disagreement (IE control codes getting sent), will fix this in a follow up task.

@azenla
Copy link
Member Author

azenla commented Aug 14, 2024

Completed!

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants