Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc): Added name and description parameters to import_group RPC method #1153

Merged
merged 19 commits into from
Oct 12, 2024

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented May 29, 2024

Summary

Added name and description parameters to import_group: https://api.limesurvey.org/classes/remotecontrol-handle.html#method_import_group.

Closes #1156

Blockers:

Test Plan

Added new integration tests.

Checklist

  • My pull request has a descriptive title.
  • I have read the CONTRIBUTING guide.
  • I have added tests that prove my fix is effective or that my feature works.
  • If appropriate, I have added necessary documentation.
  • For user-facing changes, refactorings, performance improvements or documentation updates, I have added a changelog entry using Changie.

For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:

  • Added Client.invite_participants()
  • Client.user_activation_settings() now accepts a user_activation_settings keyword argument

📚 Documentation preview 📚: https://citric--1153.org.readthedocs.build/en/1153/

Copy link

codecov bot commented May 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (daef911) to head (7907914).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          482       482           
  Branches        13        13           
=========================================
  Hits           482       482           
Flag Coverage Δ
integration 91.28% <ø> (ø)
unit 93.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the feat/import-group-name-description branch from 1f22931 to b3afedf Compare May 29, 2024 23:52
Copy link

sonarcloud bot commented Jul 3, 2024

@edgarrmondragon edgarrmondragon added the Release Package version bump label Oct 3, 2024
@edgarrmondragon edgarrmondragon changed the title feat: Added name and description parameters to import_group feat(rpc): Added name and description parameters to import_group Oct 3, 2024
@edgarrmondragon edgarrmondragon force-pushed the feat/import-group-name-description branch from 93284ac to 81edd67 Compare October 10, 2024 00:59
@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 12, 2024 00:17
@edgarrmondragon edgarrmondragon changed the title feat(rpc): Added name and description parameters to import_group feat(rpc): Added name and description parameters to import_group RPC method Oct 12, 2024
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) October 12, 2024 00:24
@edgarrmondragon edgarrmondragon added RPC Issues related to the RPC client implementation enhancement New feature or request labels Oct 12, 2024
@edgarrmondragon edgarrmondragon self-assigned this Oct 12, 2024
@edgarrmondragon edgarrmondragon merged commit ad2e498 into main Oct 12, 2024
18 of 20 checks passed
@edgarrmondragon edgarrmondragon deleted the feat/import-group-name-description branch October 12, 2024 01:17
Copy link

sonarcloud bot commented Oct 12, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Release Package version bump RPC Issues related to the RPC client implementation
Projects
Development

Successfully merging this pull request may close these issues.

Feature: Add name and description parameters of import_group
2 participants