Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): Added a new method to refresh the REST session token #1190

Merged
merged 15 commits into from
Oct 12, 2024

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Sep 22, 2024

Summary

Test Plan

Checklist

  • My pull request has a descriptive title.
  • I have read the CONTRIBUTING guide.
  • I have added tests that prove my fix is effective or that my feature works.
  • If appropriate, I have added necessary documentation.
  • For user-facing changes, refactorings, performance improvements or documentation updates, I have added a changelog entry using Changie.

For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:

  • Added Client.invite_participants()
  • Client.user_activation_settings() now accepts a user_activation_settings keyword argument

📚 Documentation preview 📚: https://citric--1190.org.readthedocs.build/en/1190/

@edgarrmondragon edgarrmondragon force-pushed the rest-token-refresh branch 2 times, most recently from 218c182 to 41f9f9c Compare September 22, 2024 04:26
Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4c00c7a) to head (e4ac0f7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1190   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          482       489    +7     
  Branches        13        13           
=========================================
+ Hits           482       489    +7     
Flag Coverage Δ
integration 91.41% <100.00%> (+0.12%) ⬆️
unit 93.25% <55.55%> (-0.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon added the REST Issues related to the REST client implementation label Sep 22, 2024
@edgarrmondragon edgarrmondragon added this to the REST API Support milestone Sep 22, 2024
@edgarrmondragon edgarrmondragon changed the title feat(rest): Added a new method to refresh the session token feat(rest): Added a new method to refresh the REST session token Oct 12, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review October 12, 2024 00:19
@edgarrmondragon edgarrmondragon enabled auto-merge (squash) October 12, 2024 00:24
@edgarrmondragon edgarrmondragon added the enhancement New feature or request label Oct 12, 2024
@edgarrmondragon edgarrmondragon self-assigned this Oct 12, 2024
Copy link

sonarcloud bot commented Oct 12, 2024

@edgarrmondragon edgarrmondragon merged commit c033062 into main Oct 12, 2024
39 checks passed
@edgarrmondragon edgarrmondragon deleted the rest-token-refresh branch October 12, 2024 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request REST Issues related to the REST client implementation
Projects
Development

Successfully merging this pull request may close these issues.

2 participants