Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support the new quota action options in LimeSurvey 6.6.7+ #1218

Merged

Conversation

edgarrmondragon
Copy link
Owner

@edgarrmondragon edgarrmondragon commented Nov 12, 2024

Summary

Test Plan

Checklist

  • My pull request has a descriptive title.
  • I have read the CONTRIBUTING guide.
  • I have added tests that prove my fix is effective or that my feature works.
  • If appropriate, I have added necessary documentation.
  • For user-facing changes, refactorings, performance improvements or documentation updates, I have added a changelog entry using Changie.

For both the title of the PR and the changelog entry, prefer simple past tense or constructions with "now". For example:

  • Added Client.invite_participants()
  • Client.user_activation_settings() now accepts a user_activation_settings keyword argument

📚 Documentation preview 📚: https://citric--1218.org.readthedocs.build/en/1218/

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (58d7ac5) to head (fbc397a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1218   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          489       495    +6     
  Branches        13        13           
=========================================
+ Hits           489       495    +6     
Flag Coverage Δ
integration 91.51% <100.00%> (+0.10%) ⬆️
unit 93.33% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/additional-quota-selection-options branch 8 times, most recently from 7dc24f5 to 08fc5fa Compare November 13, 2024 00:22
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/additional-quota-selection-options branch from 08fc5fa to 235cad8 Compare November 13, 2024 00:26
Copy link

sonarcloud bot commented Nov 13, 2024

@edgarrmondragon edgarrmondragon self-assigned this Nov 13, 2024
@edgarrmondragon edgarrmondragon added enhancement New feature or request RPC Issues related to the RPC client implementation python Pull requests that update Python code labels Nov 13, 2024
@edgarrmondragon edgarrmondragon marked this pull request as ready for review November 13, 2024 00:41
@edgarrmondragon edgarrmondragon merged commit 55ac480 into main Nov 13, 2024
66 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/additional-quota-selection-options branch November 13, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code RPC Issues related to the RPC client implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants