Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant INSECURESECRETS environment variables generated for Postgres compose file #467

Closed
lindseysimple opened this issue Oct 7, 2024 · 0 comments · Fixed by #472
Closed
Assignees
Labels
bug Something isn't working

Comments

@lindseysimple
Copy link
Contributor

🐞 Bug Report

Affected Services [REQUIRED]

The issue is located in: docker compose file.

Is this a regression?

No.

Description and Minimal Reproduction [REQUIRED]

Follow the instructions to generate a docker compose file using Postgres as database in secure mode by running the following command:

make gen keeper mqtt-bus postgres

🔥 Exception or Error

The following INSECURESECRETS_DB related environment variables with empty string values are generated in several service sections which use the database:


  core-common-config-bootstrapper:
      environment:
          ALL_SERVICES_WRITABLE_INSECURESECRETS_DB_SECRETDATA_PASSWORD: ""
          ALL_SERVICES_WRITABLE_INSECURESECRETS_DB_SECRETDATA_USERNAME: ""
          ALL_SERVICES_WRITABLE_INSECURESECRETS_DB_SECRETNAME: ""
...

  core-data:
      environment:
          WRITABLE_INSECURESECRETS_DB_SECRETDATA_PASSWORD: ""
          WRITABLE_INSECURESECRETS_DB_SECRETDATA_USERNAME: ""
          WRITABLE_INSECURESECRETS_DB_SECRETNAME: ""
...

Expected Result:

The above INSECURESECRETS_DB related environment variables are only needed while using Postgres in non-secure mode.

make gen no-secty keeper mqtt-bus postgres

🌍 Your Environment

Deployment Environment:

EdgeX Version [REQUIRED]:

Anything else relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Odessa Done
2 participants