Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Upgrade CodeQL modules, enable addl checkers #4080

Merged
merged 1 commit into from
Jul 6, 2022
Merged

build: Upgrade CodeQL modules, enable addl checkers #4080

merged 1 commit into from
Jul 6, 2022

Conversation

bnevis-i
Copy link
Collaborator

@bnevis-i bnevis-i commented Jul 5, 2022

Signed-off-by: Bryon Nevis bryon.nevis@intel.com

If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-go/blob/main/.github/Contributing.md

PR Checklist

Please check if your PR fulfills the following requirements:

  • I am not introducing a breaking change (if you are, flag in conventional commit message with BREAKING CHANGE: describing the break)
  • I am not introducing a new dependency (add notes below if you are)
  • I have added unit tests for the new feature or bug fix (if not, why?)
  • I have fully tested (add details below) this the new feature or bug fix (if not, why?)
  • I have opened a PR for the related docs change (if not, why?)

Testing Instructions

Theoretically, only affects GitHub scanning, and there is nothing to "test" with this change.

New Dependency Instructions (If applicable)

Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
@bnevis-i bnevis-i added the hold Intended for PRs we want to flag for ongoing review label Jul 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
6.0% 6.0% Duplication

@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Jul 5, 2022

Hold until have a chance to look at the CodeQL results.

@bnevis-i bnevis-i removed the hold Intended for PRs we want to flag for ongoing review label Jul 5, 2022
@bnevis-i
Copy link
Collaborator Author

bnevis-i commented Jul 5, 2022

Removed hold. Reviewers: Please inspect "Code scanning results / CodeQL" actions for effect of this change.

@codecov-commenter
Copy link

Codecov Report

Merging #4080 (7698dd7) into main (11a51fe) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4080   +/-   ##
=======================================
  Coverage   47.27%   47.27%           
=======================================
  Files         114      114           
  Lines        9850     9850           
=======================================
  Hits         4657     4657           
  Misses       4805     4805           
  Partials      388      388           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a51fe...7698dd7. Read the comment docs.

Copy link
Member

@lenny-goodell lenny-goodell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bnevis-i bnevis-i merged commit c49e1d0 into edgexfoundry:main Jul 6, 2022
@bnevis-i bnevis-i deleted the issue-4079 branch July 6, 2022 19:37
@bnevis-i bnevis-i linked an issue Jul 22, 2022 that may be closed by this pull request
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade CodeQL actions
3 participants