-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add snap support #436
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes edgexfoundry#369 Signed-off-by: Bryon Nevis <bryon.nevis@intel.com>
Bumps [github.com/pelletier/go-toml](https://github.com/pelletier/go-toml) from 1.9.3 to 1.9.4. - [Release notes](https://github.com/pelletier/go-toml/releases) - [Commits](pelletier/go-toml@v1.9.3...v1.9.4) --- updated-dependencies: - dependency-name: github.com/pelletier/go-toml dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
- add initial files from Ian Johnson's branch - add `go mod tidy` in part:edgex-ui - update snap build to use go 1.16 - delete go build from source Signed-off-by: MonicaisHer <beilimengmeng@gmail.com>
add missing config path to edgex-ui-wrapper.sh Signed-off-by: MonicaisHer <beilimengmeng@gmail.com>
-remove deprecated version-script -update version to 1.0 -update summary and description -add icon -add epoch -remove architectures: armhf and i386 Signed-off-by: MonicaisHer <beilimengmeng@gmail.com>
Signed-off-by: Huaqiao Zhang <huaqiaoz@vmware.com>
7192df8
to
de62624
Compare
update config path for solving 404 page not found issue Signed-off-by: MonicaisHer <beilimengmeng@gmail.com>
de62624
to
6547e38
Compare
badboy-huaqiao
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, next time please do rebase operation before submitting PR
Thank you, I will do it next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/master/.github/Contributing.md.
What is the current behavior?
Issue Number:
What is the new behavior?
Does this PR introduce a breaking change?
New Imports
Specific Instructions
Snap test guideline:
Reminder:
Download edgex-ui and snapcraft it:
About 4 minutes, we should see:
Install edgex-ui snap and edgexfoundry snap:
After these steps, edgex-ui and edgexfoundry will automatically running
Check:
we should see:
Configure edgexfoundry:
When we use Edgex UI work for streams, there is a problem of 502 Bad gateway. Because the Rest API of eKuiper in EdgeX uses port 59720 instead of the default 9081. So please change 9081 to 59720:
Chang: restPort: 9081
To: restPort: 59720
Use edgex-ui:
Open this in your brower: http://localhost:4000![img](https://camo.githubusercontent.com/ae28bc075ffa08848d9d617e9b4348537144e09a17c769a924b1df4aa50037d7/68747470733a2f2f6c68332e676f6f676c6575736572636f6e74656e742e636f6d2f4e68666766516c76614355786d745a6f39593164625a70464e35766e644e4a33664b346c56706c4c435653536b6745374238446b786775496c4646374c416758726345587939616d424a37444532514c547142556b78545143516e5674516b356d455a4c65573854643145486a6c4d6a374e564a6b6b6f7a3635624176716b3645375647716377753d7330)
We should see this:
Other information